[Hackfest] three minor issues

Neil Conway neilc at samurai.com
Tue Mar 29 23:13:36 EST 2005


(1) Trying to build SC 0.5 on OSX yields:

g++ -I../client -g -Wall   -c -o GameConfig.o GameConfig.C
GameConfig.C: In static member function `static bool
    GameConfig::ReadConfigFile(const std::string&)':
GameConfig.C:70: error: no matching function for call to `getline(char**,
    size_t*, FILE*&)'
GameConfig.C:85: error: no matching function for call to `getline(char**,
    size_t*, FILE*&)'
make[1]: *** [GameConfig.o] Error 1

I would imagine the same would apply on other non-GNU libc systems.

(2) Spells.C defines SPL_DISEASE as:

     gestureList.push_back(GesturePair(GST_POINT, GST_NOTHING));
     gestureList.push_back(GesturePair(GST_SNAP, GST_NOTHING));
     gestureList.push_back(GesturePair(GST_FINGER, GST_NOTHING));
     gestureList.push_back(GesturePair(GST_FINGER, GST_NOTHING));
     gestureList.push_back(GesturePair(GST_FINGER, GST_NOTHING));
     gestureList.push_back(GesturePair(GST_FINGER, GST_CLAP));

The last gesture disagrees with the spellcast man page -- it should be a 
double-handed clap. It might also be a good idea to check that either 
the secondaryGesture of a GesturePair is GST_NOTHING, or it is the same 
as the primaryGesture (excepting special cases like SPL_STAB1).

(3) Last I checked (SC 0.3), the code allowed a wizard to attack with 
two knives at once (SPL_STAB and SPL_STAB1). If that's still the case, 
it contradicts the spellcast man page.

-Neil



More information about the Hackfest mailing list